Visibility In OOP
Note: I removed a bunch of introductary text which used to be here.
I came across this talk by Marco Ocramius, Extremely Defensive PHP.
In this talk Marco discussed extremely defensive programming practices in PHP; practices that work well for long lived projects. This talk inspired me to put down my own ideas in this post.
The gist of the talk is that you should be writing stupid proof code. Code that can only be used in a way that you made it to be used for. No one should be able to use the code in any other manner than is specified. It's a really good talk and I recommend that you go ahead and watch the video.
Marco covered a lot of ground on visibility and accessibility in his blog post, and I am going to put my thoughts on top of this very blog post.
I compiled a list of points made my Marco.
- Prevent massive inheritance chain of doom
- Encourage composition
- Encapsulate properly
- Work towards abstraction
Lets get started with this list. If you want to achieve most of it, I have four tips for you.
- Make extensible class abstract
- Make non abstract class final
- Non abstract class can have only public or private members
- Only abstract class can have protected members
Make extensible class abstract.
Extending a class is a separate use case in its own. Most of the times you extend a non-abstract class you are going to violate SRP.
Marking a class
abstract takes away the responsibility of the class and you can only use it for functionality that is truly re-usable in an abstract sense. This will force you to think about the concerns of your code and separate them.
Inject dependencies instead of inheriting from them, and if you still believe that a class must extend from a non-abstract class, you need to re-factor this would-be-parent class and extract that logic which make you want to extend the class so desperately into an abstract class.
Make non abstract class final.
Every class which is not abstract has its own concerns to deal with. When you extend it you are essentially adding concerns to the class. When you extend, the child class is now responsible for the concerns of its own plus the concerns of its parent.
Marking a class
final tells the consumer to compose functionality, and it also restricts the level of accessibility to only public API, which ultimately make your code stupid proof.
Non abstract class can have only public or private members.
If a class is not abstract, its responsibilities are assumed to be saturated, at least for the current cycle. What that mean is, that no one should be adding any more functionality to it. Consumers should only be able to use the functionality provided by it.
If you can have only one of public or a privately accessible method, you no longer have to worry about the extension. This also allows you to change the underlying functionality of public API as much as you want, without breaking inheritable functionality of the class.
And guess what? You can make it
final without even thinking about it.
Only abstract class can have protected members.
For most of the people I know out there, it is a subconscious decision to make every property protected. Why? I don't know. And I almost stopped caring, until today.
Protected members are inherited by child classes and an abstract class completely justifies a protected member. If the class is abstract and it has a protected member it actively indicates that the member has a function which is not supposed to be available publicly but is a requirement for extension. Otherwise it is just another private member with a misleading access level.
I recommend that you make it a habit to declare members
private, and question yourself every time you declare a member with
protected access level. If you think that the
protected access is actually required it is most likely going to be the hidden piece of re-usable code.
Putting it all together
It will probably make you want to kill me but if you maintain at least one open source project you'll know how important it is to clearly define the behavioral specifications for your code.
You can control every extension point in a project using five keywords and enforce the expectations. Stupid proof code will kick you in the butt every time you make a stupid decision. It will force you to think and wonder about stuff that you could've never had thought about.
- Slides presented by Marco are available here